Upgrade to Panda v7 - support key rotation #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
7 tasks
rtyley
force-pushed
the
upgrade-to-panda-v7-support-key-rotation
branch
from
7bbcb88
to
ecfaf18
Compare
rtyley
force-pushed
the
update-to-java-11
branch
from
8a075db
to
21ab1fc
Compare
rtyley
force-pushed
the
upgrade-to-panda-v7-support-key-rotation
branch
from
ecfaf18
to
b248735
Compare
This upgrades Panda from v5 to v7, allowing us to use key rotation as introduced with guardian/pan-domain-authentication#150.
rtyley
force-pushed
the
upgrade-to-panda-v7-support-key-rotation
branch
from
b248735
to
3b8d84a
Compare
rtyley
commented
Sep 19, 2024
Comment on lines
-35
to
36
| val panDomainSettings = new PanDomainAuthSettingsRefresher( | ||
| val panDomainSettings = PanDomainAuthSettingsRefresher( | ||
| domain = config.pandaDomain, | ||
| system = config.pandaSystemIdentifier, | ||
| bucketName = config.pandaBucketName, | ||
| settingsFileKey= config.pandaSettingsFileKey, | ||
| s3Client = AWS.S3Client, | ||
| S3BucketLoader.forAwsSdkV1(AWS.S3Client, "pan-domain-auth-settings") | ||
| ) |
There was a problem hiding this comment.
This PR:
...introduced the new S3BucketLoader abstraction, which simplifies constructing a PanDomainAuthSettingsRefresher and means that Panda is no longer tied to AWS SDK v1 - an alternative AWS SDK v2 implementation of S3BucketLoader could be introduced.
Fweddi
approved these changes
Sep 20, 2024
Darn, you're right, will remove... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades Panda from v5 to v7, allowing us to use key rotation as introduced with guardian/pan-domain-authentication#150.
S3BucketLoaderabstraction, which simplifies constructing aPanDomainAuthSettingsRefresherand means that Panda is no longer tied to AWS SDK v1 - an alternative AWS SDK v2 implementation ofS3BucketLoadercould be introduced.This PR sits on top of:
Testing
This has been successfully deployed to CODE, and I've checked that I'm able to re-authenticate with either the updated https://tagmanager.code.dev-gutools.co.uk/ or the unmodified https://composer.code.dev-gutools.co.uk/ - and they both accept each other's cookies.